fix(websocket): improve error and close handling#66
Open
HansSchouten wants to merge 1 commit intobitvavo:masterfrom
Open
fix(websocket): improve error and close handling#66HansSchouten wants to merge 1 commit intobitvavo:masterfrom
HansSchouten wants to merge 1 commit intobitvavo:masterfrom
Conversation
HansSchouten
commented
Sep 24, 2025
HansSchouten
commented
- Use repr() when logging errors to ensure useful output even for non-string errors
- Update on_close signature to accept (code, reason) for compatibility with newer websocket-client
- Remove self.receiveThread.exit() since the exit method does not exist in receiveThread
- Log close code and reason for easier debugging
- Use repr() when logging errors to ensure useful output even for non-string errors - Update on_close signature to accept (code, reason) for compatibility with newer websocket-client - Remove self.receiveThread.exit() since the exit method does not exist in receiveThread - Log close code and reason for easier debugging
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.